[stdlib]Enable Swift 4 mode for the overlays #12608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
slavapestov
reviewed
Oct 24, 2017
cmake/modules/SwiftSource.cmake
Outdated
| @@ -257,7 +257,7 @@ function(_compile_swift_files | |||
| endif() | |||
|
|
|||
| # Force swift 3 compatibility mode for Standard Library and overlay. | |||
There was a problem hiding this comment.
This comment should be updated then
lancep
changed the title
|
@swift-ci please smoke benchmark |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci Please Test Source Compatibility |
|
@swift-ci Please smoke test compiler performance |
|
Build failed |
Build comment file:Optimized (O)Regression (5)
Improvement (4)
No Changes (325)
Unoptimized (Onone)Regression (11)
Improvement (9)
No Changes (314)
Hardware Overview |
|
Source compat suite? |
|
It might also be good to explicitly pass |
|
@swift-ci please test |
|
@swift-ci Please Test Source Compatibility |
|
Build failed |
|
Build failed |
|
@swift-ci please test OS X platform |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test OS X platform |
|
Build failed |
|
@swift-ci please test Linux platform |
|
Build failed |
|
@swift-ci Please Test Source Compatibility |
1 similar comment
|
@swift-ci Please Test Source Compatibility |
|
Ta-da! @lancep sorry, it's you =) |
|
Booo |
|
@moiseev any objections? |
jrose-apple
reviewed
Nov 3, 2017
| @@ -55,11 +55,11 @@ public extension XCUIElement { | |||
| func _XCTRegisterFailure(_ expected: Bool, _ condition: String, _ message: @autoclosure () -> String, _ file: StaticString, _ line: UInt) { | |||
| // Call the real _XCTFailureHandler. | |||
| let test = _XCTCurrentTestCase() | |||
| _XCTPreformattedFailureHandler(test, expected, file.description, line, condition, message()) | |||
| _XCTPreformattedFailureHandler(test, expected, file.description, Int(line), condition, message()) | |||
There was a problem hiding this comment.
Why not just change the argument to Int here too?
There was a problem hiding this comment.
Because that just meant a cast in more places. This is called from APIs such as XCTFail, and we can't change the signature there. So doing one cast here was less change
shahmishal
added a commit
that referenced
this pull request
Nov 3, 2017
This reverts commit f54d8b4.
graydon
added a commit
to graydon/swift
that referenced
this pull request
Nov 4, 2017
This reverts commit f54d8b4.
lancep
pushed a commit
that referenced
this pull request
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds the SDK overlays in Swift 4 mode.