Skip to content

Make Metal(Kit) overlays build in Swift 4 mode #13223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2017
Merged

Make Metal(Kit) overlays build in Swift 4 mode #13223

merged 1 commit into from
Dec 2, 2017

Conversation

lancep
Copy link
Contributor

@lancep lancep commented Dec 2, 2017

In #12608, we changed the SDK overlays to build in Swift 4 mode. We left some of them in Swift 3 mode temporarily.

This change makes the Metal and MetalKit SDK overlays build in Swift 4 mode too.

@lancep lancep requested a review from moiseev December 2, 2017 04:29
@lancep
Copy link
Contributor Author

lancep commented Dec 2, 2017

@swift-ci please smoke test

Copy link
Contributor

@moiseev moiseev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@moiseev
Copy link
Contributor

moiseev commented Dec 2, 2017

@swift-ci Please test macOS platform

@airspeedswift airspeedswift merged commit 244a272 into swiftlang:master Dec 2, 2017
@lancep lancep deleted the metal_overlays branch December 2, 2017 15:44
davidungar pushed a commit to davidungar/swift that referenced this pull request Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants