Finish and default-enable named lazy member loading #12843

graydon · 2017-11-09T19:55:47Z

This is now complete enough to consider merging, I think. All tests pass, benchmarks show a slight improvement in counters (and nothing terribly noticeable in time), various secondary projects seem to build.

DougGregor

This looks good! I so very much want to kill mirroring of protocol members :(

ematejska · 2017-11-27T17:31:41Z

@swift-ci please smoke test

ematejska · 2017-11-27T17:32:00Z

@swift-ci please test

swift-ci · 2017-11-27T17:32:20Z

Build failed
Swift Test Linux Platform
Git Sha - a3ee478059f129edb11004b297209adf58b3849c

swift-ci · 2017-11-27T17:32:21Z

Build failed
Swift Test OS X Platform
Git Sha - a3ee478059f129edb11004b297209adf58b3849c

ematejska · 2017-11-27T19:26:08Z

@swift-ci please test os x

swift-ci · 2017-11-27T20:44:43Z

Build failed
Swift Test OS X Platform
Git Sha - 9624f70a8b239224a3083ea9a05608962a9eb64d

graydon · 2017-11-29T22:16:37Z

@swift-ci please test

swift-ci · 2017-11-29T22:29:51Z

Build failed
Swift Test Linux Platform
Git Sha - 9624f70a8b239224a3083ea9a05608962a9eb64d

swift-ci · 2017-11-29T23:08:33Z

Build failed
Swift Test OS X Platform
Git Sha - 9624f70a8b239224a3083ea9a05608962a9eb64d

…n deserializing.

…y off.

…mber mirroring.

…mported init for now.

…tinel. The empty sentinel in the lookup table caused recursion-breaking to bottom out in slightly different order than the old eager code, making certain order-sensitive tests fail.

…atch.

graydon · 2017-12-01T06:56:57Z

@swift-ci please test

graydon · 2017-12-01T06:57:10Z

@swift-ci please smoke test compiler performance

swift-ci · 2017-12-01T06:57:17Z

Build failed
Swift Test OS X Platform
Git Sha - 9624f70a8b239224a3083ea9a05608962a9eb64d

swift-ci · 2017-12-01T06:58:12Z

Build failed
Swift Test Linux Platform
Git Sha - 9624f70a8b239224a3083ea9a05608962a9eb64d

swift-ci · 2017-12-01T07:37:19Z

Build comment file:

Summary for master smoketest

No regressions above thresholds

Debug
- debug brief
- debug detailed
Release
- release brief
- release detailed

Debug

debug brief

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (2)

name	old	new	delta	delta_pct
LLVM.NumLLVMBytesOutput	23,287,788	23,287,628	-160	-0.0%
time.swift-driver.wall	31.3s	31.1s	-212.9ms	-0.68%

debug detailed

Regressed (0)

name	old	new	delta	delta_pct

Improved (9)

name	old	new	delta	delta_pct
AST.NumImportedExternalDefinitions	47,780	45,388	-2,392	-5.01% ✅
AST.NumTotalClangImportedEntities	133,186	125,951	-7,235	-5.43% ✅
Sema.NumDeclsDeserialized	910,426	852,022	-58,404	-6.42% ✅
Sema.NumFunctionsTypechecked	27,343	26,612	-731	-2.67% ✅
Sema.NumGenericSignatureBuilders	37,037	36,604	-433	-1.17% ✅
Sema.NumLazyGenericEnvironments	185,703	172,924	-12,779	-6.88% ✅
Sema.NumLazyGenericEnvironmentsLoaded	18,675	18,354	-321	-1.72% ✅
Sema.NumLazyIterableDeclContexts	153,662	147,510	-6,152	-4.0% ✅
Sema.NumTypesDeserialized	972,796	896,403	-76,393	-7.85% ✅

Unchanged (delta < 1.0% or delta < 100.0ms) (14)

name	old	new	delta	delta_pct
AST.NumLoadedModules	6,369	6,369	0	0.0%
AST.NumUsedConformances	2,713	2,713	0	0.0%
IRModule.NumIRBasicBlocks	65,525	65,525	0	0.0%
IRModule.NumIRFunctions	32,945	32,945	0	0.0%
IRModule.NumIRGlobals	36,442	36,442	0	0.0%
IRModule.NumIRInsts	702,293	702,293	0	0.0%
IRModule.NumIRValueSymbols	59,735	59,735	0	0.0%
LLVM.NumLLVMBytesOutput	23,287,788	23,287,628	-160	-0.0%
SILModule.NumSILGenFunctions	14,638	14,638	0	0.0%
SILModule.NumSILOptFunctions	25,780	25,780	0	0.0%
Sema.NumConformancesDeserialized	115,216	114,761	-455	-0.39%
Sema.NumConstraintScopes	445,934	445,209	-725	-0.16%
Sema.NumDeclsValidated	28,449	28,449	0	0.0%
Sema.NumTypesValidated	97,068	97,068	0	0.0%

Release

release brief

Regressed (0)

name	old	new	delta	delta_pct

Improved (0)

name	old	new	delta	delta_pct

Unchanged (delta < 1.0% or delta < 100.0ms) (2)

name	old	new	delta	delta_pct
LLVM.NumLLVMBytesOutput	28,771,864	28,771,880	16	0.0%
time.swift-driver.wall	68.2s	67.7s	-461.3ms	-0.68%

release detailed

Regressed (0)

name	old	new	delta	delta_pct

Improved (7)

name	old	new	delta	delta_pct
AST.NumImportedExternalDefinitions	7,421	7,018	-403	-5.43% ✅
AST.NumTotalClangImportedEntities	22,601	21,675	-926	-4.1% ✅
Sema.NumDeclsDeserialized	134,664	131,600	-3,064	-2.28% ✅
Sema.NumFunctionsTypechecked	7,471	7,289	-182	-2.44% ✅
Sema.NumLazyGenericEnvironments	23,800	23,029	-771	-3.24% ✅
Sema.NumLazyGenericEnvironmentsLoaded	2,665	2,567	-98	-3.68% ✅
Sema.NumTypesDeserialized	158,791	155,418	-3,373	-2.12% ✅

Unchanged (delta < 1.0% or delta < 100.0ms) (16)

name	old	new	delta	delta_pct
AST.NumLoadedModules	227	227	0	0.0%
AST.NumUsedConformances	2,719	2,719	0	0.0%
IRModule.NumIRBasicBlocks	61,432	61,432	0	0.0%
IRModule.NumIRFunctions	26,542	26,542	0	0.0%
IRModule.NumIRGlobals	34,111	34,111	0	0.0%
IRModule.NumIRInsts	581,746	581,746	0	0.0%
IRModule.NumIRValueSymbols	54,235	54,235	0	0.0%
LLVM.NumLLVMBytesOutput	28,771,864	28,771,880	16	0.0%
SILModule.NumSILGenFunctions	10,842	10,842	0	0.0%
SILModule.NumSILOptFunctions	19,704	19,704	0	0.0%
Sema.NumConformancesDeserialized	68,815	68,815	0	0.0%
Sema.NumConstraintScopes	425,680	425,502	-178	-0.04%
Sema.NumDeclsValidated	17,632	17,632	0	0.0%
Sema.NumGenericSignatureBuilders	4,559	4,530	-29	-0.64%
Sema.NumLazyIterableDeclContexts	12,717	12,668	-49	-0.39%
Sema.NumTypesValidated	31,082	31,082	0	0.0%

graydon · 2017-12-01T07:59:13Z

@swift-ci please test and merge

graydon · 2017-12-01T08:15:02Z

@swift-ci please test and merge

aschwaighofer · 2017-12-01T15:25:44Z

This very likely broke source compat:

https://ci.swift.org/job/swift-master-source-compat-suite/838

graydon · 2017-12-01T16:33:16Z

Ugh. I've got a dentist appointment just now but will be back in a bit to fix this. If it's urgent, reverting only 3de4297 ought to do the trick (turning the flag off by default).

graydon · 2017-12-01T16:34:40Z

(Sorry! Ran the smoke-compat subset, evidently launchscreensnapshot is doing something special)

aschwaighofer · 2017-12-01T16:36:41Z

@graydon I have reverted this PR in #13204

graydon · 2017-12-01T16:37:21Z

K. Sorry. Will qualify more thoroughly before retrying.

swiftlang deleted a comment from swift-ci Nov 9, 2017

swiftlang deleted a comment from swift-ci Nov 10, 2017

graydon force-pushed the force-on-named-lazy-member-loading branch from e51d426 to 7fd3604 Compare November 10, 2017 08:31

swiftlang deleted a comment from swift-ci Nov 11, 2017

swiftlang deleted a comment from swift-ci Nov 13, 2017

graydon force-pushed the force-on-named-lazy-member-loading branch from 7fd3604 to a3ee478 Compare November 14, 2017 16:49

swiftlang deleted a comment from swift-ci Nov 14, 2017

swiftlang deleted a comment from swift-ci Nov 15, 2017

swiftlang deleted a comment from swift-ci Nov 16, 2017

graydon force-pushed the force-on-named-lazy-member-loading branch 3 times, most recently from 04ff4ec to 71f8994 Compare November 18, 2017 01:17

graydon changed the title ~~[DO NOT MERGE] Force on named lazy member loading, for benchmarking.~~ Finish and default-enable named lazy member loading Nov 18, 2017

graydon requested review from jrose-apple and DougGregor November 18, 2017 07:01

swiftlang deleted a comment from swift-ci Nov 18, 2017

DougGregor approved these changes Nov 22, 2017

View reviewed changes

graydon added 2 commits November 30, 2017 22:01

[NamedLazyMemberLoading] Eat errors properly with llvm::consumeError.

412bf0b

[NamedLazyMemberLoading] Add "loading members" pretty stack trace whe…

cafb596

…n deserializing.

graydon added 9 commits November 30, 2017 22:01

[NamedLazyMemberLoading] Flip flag polarity: on by default, optionall…

3de4297

…y off.

[ClangImporter] call addImplicitDestructor() on imported CF types.

0e3bde6

[NamedLazyMemberLoading] Bail on cases that interact with protocol me…

b32f4f4

…mber mirroring.

[NamedLazyMemberLoading] Give up trying to break recursion on clang-i…

dfc67d6

…mported init for now.

[NamedLazyMemberLoading] Use per-IDC recursion-breaking flag, not sen…

9e18594

…tinel. The empty sentinel in the lookup table caused recursion-breaking to bottom out in slightly different order than the old eager code, making certain order-sensitive tests fail.

[NamedLazyMemberLoading] Return empty vector rather than None on no-m…

d3bcdfd

…atch.

[NamedLazyMemberLoading] Support named loading from ObjC categories.

a967f8c

[NamedLazyMemberLoading] Tolerate mid-flight getMembers() calls better.

094ee2f

[NamedLazyMemberLoading] Update tests with improved output.

61885b0

graydon force-pushed the force-on-named-lazy-member-loading branch from 9624f70 to 61885b0 Compare December 1, 2017 06:56

swiftlang deleted a comment from swift-ci Dec 1, 2017

[NamedLazyMemberLoading] Add testcase for categories.

e624e68

swift-ci merged commit 7e6f7e1 into swiftlang:master Dec 1, 2017

aschwaighofer mentioned this pull request Dec 1, 2017

Revert "Finish and default-enable named lazy member loading" #13204

Merged

graydon mentioned this pull request Dec 2, 2017

Force on named lazy member loading retry #13216

Merged

Finish and default-enable named lazy member loading #12843

Finish and default-enable named lazy member loading #12843

Uh oh!

Conversation

graydon commented Nov 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DougGregor left a comment

Choose a reason for hiding this comment

Uh oh!

ematejska commented Nov 27, 2017

Uh oh!

ematejska commented Nov 27, 2017

Uh oh!

swift-ci commented Nov 27, 2017

Uh oh!

swift-ci commented Nov 27, 2017

Uh oh!

ematejska commented Nov 27, 2017

Uh oh!

swift-ci commented Nov 27, 2017

Uh oh!

graydon commented Nov 29, 2017

Uh oh!

swift-ci commented Nov 29, 2017

Uh oh!

swift-ci commented Nov 29, 2017

Uh oh!

graydon commented Dec 1, 2017

Uh oh!

graydon commented Dec 1, 2017

Uh oh!

swift-ci commented Dec 1, 2017

Uh oh!

swift-ci commented Dec 1, 2017

Uh oh!

swift-ci commented Dec 1, 2017

Build comment file:

Summary for master smoketest

Debug

debug brief

debug detailed

Release

release brief

release detailed

Uh oh!

graydon commented Dec 1, 2017

Uh oh!

graydon commented Dec 1, 2017

Uh oh!

aschwaighofer commented Dec 1, 2017

Uh oh!

graydon commented Dec 1, 2017

Uh oh!

graydon commented Dec 1, 2017

Uh oh!

aschwaighofer commented Dec 1, 2017

Uh oh!

graydon commented Dec 1, 2017

Uh oh!

Uh oh!

graydon commented Nov 9, 2017 •

edited

Loading