Skip to content

Force on named lazy member loading retry #13216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Dec 4, 2017
Merged

Force on named lazy member loading retry #13216

merged 15 commits into from
Dec 4, 2017

Conversation

graydon
Copy link
Contributor

@graydon graydon commented Dec 2, 2017

This is another attempt at enabling-by-default named lazy member loading. Includes a fix for the problem discovered in the source-compat suite with the previous attempt (PR #12843).

graydon added 12 commits December 1, 2017 16:52
@graydon
[NamedLazyMemberLoading] Add "loading members" pretty stack trace whe…
758a016 
…n deserializing.
@graydon
[NamedLazyMemberLoading] Flip flag polarity: on by default, optionall…
3726e69 
…y off.
@graydon
[ClangImporter] call addImplicitDestructor() on imported CF types.
eba924b
@graydon
[NamedLazyMemberLoading] Bail on cases that interact with protocol me…
8813935 
…mber mirroring.
@graydon
[NamedLazyMemberLoading] Give up trying to break recursion on clang-i…
a6701a8 
…mported init for now.
@graydon
[NamedLazyMemberLoading] Use per-IDC recursion-breaking flag, not sen…
464dc1b 
…tinel.

The empty sentinel in the lookup table caused recursion-breaking to bottom
out in slightly different order than the old eager code, making certain
order-sensitive tests fail.
@graydon
[NamedLazyMemberLoading] Return empty vector rather than None on no-m…
9d7b26f 
…atch.
@graydon
[NamedLazyMemberLoading] Support named loading from ObjC categories.
3e76aeb
@graydon
[NamedLazyMemberLoading] Tolerate mid-flight getMembers() calls better.
ce28efb
@graydon
[NamedLazyMemberLoading] Update tests with improved output.
2a2473d
@graydon
[NamedLazyMemberLoading] Add testcase for categories.
c700e2e
@graydon
[NamedLazyMemberLoading] Handle nominals with mix of added/lazy members.
7a9bc26
@graydon
Copy link
Contributor Author

graydon commented Dec 2, 2017

@swift-ci please test

@graydon
Copy link
Contributor Author

graydon commented Dec 2, 2017

@swift-ci Please Test Source Compatibility

@graydon
Copy link
Contributor Author

graydon commented Dec 2, 2017

@swift-ci please test

@graydon
Copy link
Contributor Author

graydon commented Dec 2, 2017

@swift-ci Please Test Source Compatibility

@graydon
Copy link
Contributor Author

graydon commented Dec 2, 2017

@swift-ci Please Smoke Test Compiler Performance

@swift-ci
Copy link
Contributor

swift-ci commented Dec 2, 2017

Build failed
Swift Test Linux Platform
Git Sha - 7a9bc26

@swift-ci
Copy link
Contributor

swift-ci commented Dec 2, 2017

Build failed
Swift Test OS X Platform
Git Sha - 7a9bc26

@swift-ci
Copy link
Contributor

swift-ci commented Dec 2, 2017

Build comment file:

Summary for master smoketest

No regressions above thresholds

Debug

debug brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 23,285,000 23,284,844 -156 -0.0%
time.swift-driver.wall 30.8s 30.7s -132.8ms -0.43%

debug detailed

Regressed (0)
name old new delta delta_pct
Improved (9)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 47,780 45,605 -2,175 -4.55% ✅
AST.NumTotalClangImportedEntities 133,202 128,138 -5,064 -3.8% ✅
Sema.NumDeclsDeserialized 899,348 841,781 -57,567 -6.4% ✅
Sema.NumFunctionsTypechecked 27,343 26,637 -706 -2.58% ✅
Sema.NumGenericSignatureBuilders 36,829 36,436 -393 -1.07% ✅
Sema.NumLazyGenericEnvironments 178,983 166,729 -12,254 -6.85% ✅
Sema.NumLazyGenericEnvironmentsLoaded 18,433 18,120 -313 -1.7% ✅
Sema.NumLazyIterableDeclContexts 153,982 148,007 -5,975 -3.88% ✅
Sema.NumTypesDeserialized 963,809 888,623 -75,186 -7.8% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (14)
name old new delta delta_pct
AST.NumLoadedModules 6,369 6,369 0 0.0%
AST.NumUsedConformances 2,713 2,713 0 0.0%
IRModule.NumIRBasicBlocks 65,495 65,495 0 0.0%
IRModule.NumIRFunctions 32,935 32,935 0 0.0%
IRModule.NumIRGlobals 36,442 36,442 0 0.0%
IRModule.NumIRInsts 702,158 702,158 0 0.0%
IRModule.NumIRValueSymbols 59,725 59,725 0 0.0%
LLVM.NumLLVMBytesOutput 23,285,000 23,284,844 -156 -0.0%
SILModule.NumSILGenFunctions 14,638 14,638 0 0.0%
SILModule.NumSILOptFunctions 25,709 25,709 0 0.0%
Sema.NumConformancesDeserialized 115,021 114,566 -455 -0.4%
Sema.NumConstraintScopes 417,853 417,153 -700 -0.17%
Sema.NumDeclsValidated 28,449 28,449 0 0.0%
Sema.NumTypesValidated 97,068 97,068 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 28,802,432 28,802,448 16 0.0%
time.swift-driver.wall 66.8s 66.6s -188.0ms -0.28%

release detailed

Regressed (0)
name old new delta delta_pct
Improved (7)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 7,421 7,051 -370 -4.99% ✅
AST.NumTotalClangImportedEntities 22,601 21,940 -661 -2.92% ✅
Sema.NumDeclsDeserialized 131,560 128,221 -3,339 -2.54% ✅
Sema.NumFunctionsTypechecked 7,471 7,299 -172 -2.3% ✅
Sema.NumLazyGenericEnvironments 21,926 21,245 -681 -3.11% ✅
Sema.NumLazyGenericEnvironmentsLoaded 2,617 2,523 -94 -3.59% ✅
Sema.NumTypesDeserialized 156,267 152,736 -3,531 -2.26% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (16)
name old new delta delta_pct
AST.NumLoadedModules 227 227 0 0.0%
AST.NumUsedConformances 2,719 2,719 0 0.0%
IRModule.NumIRBasicBlocks 61,475 61,475 0 0.0%
IRModule.NumIRFunctions 26,597 26,597 0 0.0%
IRModule.NumIRGlobals 34,113 34,113 0 0.0%
IRModule.NumIRInsts 581,886 581,886 0 0.0%
IRModule.NumIRValueSymbols 54,292 54,292 0 0.0%
LLVM.NumLLVMBytesOutput 28,802,432 28,802,448 16 0.0%
SILModule.NumSILGenFunctions 10,842 10,842 0 0.0%
SILModule.NumSILOptFunctions 19,650 19,650 0 0.0%
Sema.NumConformancesDeserialized 68,558 68,558 0 0.0%
Sema.NumConstraintScopes 397,599 397,431 -168 -0.04%
Sema.NumDeclsValidated 17,632 17,632 0 0.0%
Sema.NumGenericSignatureBuilders 4,540 4,517 -23 -0.51%
Sema.NumLazyIterableDeclContexts 12,882 12,837 -45 -0.35%
Sema.NumTypesValidated 31,082 31,082 0 0.0%

@graydon graydon mentioned this pull request Dec 4, 2017
Closed
@graydon graydon merged commit 8bcfafe into swiftlang:master Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graydon @swift-ci