IRGen: ensure that ObjC sections match on all targets #13225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
force-pushed
the
objc-irgen
branch
2 times, most recently
from
41d1f56 to
f5c4f80
Compare
Adjust the IRGen for ObjC interop to ensure that the section that metadata is emitted into the correct section for non-MachO targets. This also adds a more comprehensive test for ensuring that the IRGen can now be tested on all targets. Since the ObjC interop is now controllable via the driver, this test does not require that the objc_interop feature is present as it is a IRGen test. This is the first step to remove the `REQUIRES: objc_interop` from the IRGen tests.
|
@swift-ci please smoke test and merge |
|
Potential fix: dfa4b77 |
|
@aschwaighofer weird, wonder why. Thanks for the fix! |
|
This test breaks for me when I don't build the iOS stdlib. I think it's because the importer is still trying to look things up in the standard library. |
|
@compnerd I just hit a failure on this test as a result of having a stale iOS stdlib sitting around. The test should be split up by target output type with each guarded by |
|
@rudkx sure, I can split it up into three different tests. Sorry, still used to the LLVM style of working where just the architecture matters. |
|
PR14063 splits up the test into three copies. We can discuss whether that is a good idea or not there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the IRGen for ObjC interop to ensure that the section that
metadata is emitted into the correct section for non-MachO targets.
This also adds a more comprehensive test for ensuring that the IRGen can
now be tested on all targets. Since the ObjC interop is now
controllable via the driver, this test does not require that the
objc_interop feature is present as it is a IRGen test.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.