Skip to content

test: triplicate a test #14063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2018
Merged

test: triplicate a test #14063

merged 1 commit into from
Jan 24, 2018

Conversation

compnerd
Copy link
Member

The runtime can be out of date and cause spurious failures. Copy the
test over thrice to deal with that. Requested by Mark Lacey.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

CC: @rudkx @jrose-apple

Not sure if Jordan has strong opinions on having three copies of the test (I think that it is probably better to rely on developers to do clean builds than have three copies of the test).

@compnerd
Copy link
Member Author

@swift-ci please test

@jrose-apple
Copy link
Contributor

No, I'm with Mark, since there's plenty of times when I configure to build the iOS stdlib but haven't built it yet. (And left a comment to that effect back in December.) You need to add the REQUIRES check to actually make this useful, though.

@compnerd
Copy link
Member Author

Actually, looking at this again, I had tried to make it not depend on the stdlib ... note that it uses -parse-stdlib so it shouldn't be dependent on the stdlib, no?

@compnerd
Copy link
Member Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 3f1c720ba36a08ffb92c0b3cac5bd4f9e51897c4

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 3f1c720ba36a08ffb92c0b3cac5bd4f9e51897c4

@jrose-apple
Copy link
Contributor

As I said on #13225, it's probably still using the stdlib because you're importing types from C. I don't think the importer is set up to avoid looking things up in -parse-stdlib mode, and it's not really worth your time to do that.

The runtime can be out of date and cause spurious failures.  Copy the
test over thrice to deal with that.  Requested by Mark Lacey.
@compnerd
Copy link
Member Author

@swift-ci please test and merge

@swift-ci swift-ci merged commit 2df21ad into swiftlang:master Jan 24, 2018
@compnerd compnerd deleted the triplicate branch January 24, 2018 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants