[Parse] Lexer build backtick trivia around espaced identifier token #13631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
reviewed
Dec 28, 2017
| @@ -0,0 +1,4 @@ | |||
| // RUN: %swift-syntax-test -input-source-filename %s -serialize-raw-tree > %t | |||
There was a problem hiding this comment.
Since we are actively developing/modifying syntax tree structure, we expect this output will be obsoleted very soon. I don't think we need this test.
see also: #13485 (comment)
There was a problem hiding this comment.
Thanks review.
Ah I have also felt that this test is fragile .
Ok, I will remove this.
| @@ -0,0 +1,4 @@ | |||
| // RUN: %swift-syntax-test -input-source-filename %s -dump-full-tokens > %t | |||
There was a problem hiding this comment.
Essentially, -dump-full-tokens is for debug use only. We don't want to keep this output as a formal test case.
Alternatively, could you change this to FileCheck based test?
Like:
// CHECK-LABEL: 3:25
// CHECK-NEXT: (token identifier
// CHECK-NEXT: (trivia block_comment
// CHECK-NEXT: (trivia space 1)
// CHECK-NEXT: (trivia backtick 1)
// CHECK-NEXT: (text="if")
// CHECK-NEXT: (trivia backtick 1)
// CHECK-LABEL: 4:27
// CHECK-NEXT: (token identifier
// CHECK-NEXT: ...
omochi
force-pushed
the
lex-escape-backtick
branch
from
e1ac59f to
bc88330
Compare
|
I updated commits. Please check it. |
|
@swift-ci Please test |
|
@swift-ci Please test |
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a logic that build backtick trivia before and after of escaped identifier token at two places.
First is at
swift::tokenizeWithTriviainParser.cpp.Second is at
SyntaxParsingContext::addTokeninSyntaxParsingContext.cpp.This PR moves this logic into Lexer and makes them common.
First commit is adding of testcase for existing.
To check first case, it runs
swift-syntax-test -dump-full-tokens.To check second case, it runs
swift-syntax-test -serialize-raw-tree.Second commit is actual patch.