[4.1][Lexer] Don't setEscapedIdentifier(true) for tok::eof at ArtificialEOF #14552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
changed the title
rintaro
force-pushed
the
4.1-lex-escaped-eof
branch
from
0825dd2 to
368d93b
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
https://bugs.swift.org/browse/SR-6926 This happens when the Parser re-lexing comment tokens that sets ArtificialEOF at the end of comment range. It used to cause an assertion failure: (!value || Kind == tok::identifier) && "only identifiers can be escaped identifiers"
rintaro
force-pushed
the
4.1-lex-escaped-eof
branch
from
368d93b to
339b47d
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@akyrtzi Could you review this for 4.1 branch? |
akyrtzi
approved these changes
Feb 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #14505 (and #13631 which #14505 depends on)
Explanation: Fix an assertion failure in SourceKit. During parsing for SourceKit, the parser tokenizes comments as tokens by re-lexing the source range of them. If the comment happens to be followed by escaped identifier, the Lexer tokenize the escaped identifier as
EOF, and it used to mistakingly mark them as escaped identifier, that behavior used to cause an assertion failure(!value || Kind == tok::identifier) && "only identifiers can be escaped identifiers". The normal compiler has no path for hitting this defects.Scope: SourceKit with assertion enabled. If assertion was disabled, it didn't crash.
Risk: Low.
isEscapedIdentiferflag has no meanings fortok::eoftokens.Testing: Added regression test for SourceKit.
Reviewer: @akyrtzi
SR / Radar: SR-6926 rdar://problem/37290899