[Lexer] Don't setEscapedIdentifier(true) for tok::eof at ArtificialEOF #14505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
I'm not so familiar with this part of the code but it does look like you've fixed the problem! The original test case used |
akyrtzi
approved these changes
Feb 10, 2018
https://bugs.swift.org/browse/SR-6926 This happens when the Parser re-lexing comment tokens that sets ArtificialEOF at the end of comment range. It used to cause an assertion failure: (!value || Kind == tok::identifier) && "only identifiers can be escaped identifiers"
rintaro
force-pushed
the
lex-escaped-eof
branch
from
70e8eb7 to
7667742
Compare
|
@swift-ci Please smoke test |
This was referenced Feb 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SR-6926 rdar://problem/37290899
This happens when the
Parserre-lexing comment tokens that setsArtificialEOFat the end of comment range.It used to cause an assertion failure
(!value || Kind == tok::identifier) && "only identifiers can be escaped identifiers"