Skip to content

[Python] Python class names should be CamelCase:d by convention #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2016
Merged

[Python] Python class names should be CamelCase:d by convention #1369

merged 1 commit into from
Feb 19, 2016

Conversation

practicalswift
Copy link
Contributor

No description provided.

@modocache
Copy link
Contributor

Excellent! I'd also love to see a pull request for a similar convention in the reverse case--one that converts some of the camelCase functions in SwiftBuildSupport.py to snake_case.

Thanks for all the Python improvements, @practicalswift! 👍

nadavrot added a commit that referenced this pull request Feb 19, 2016
[Python] Python class names should be CamelCase:d by convention
@nadavrot nadavrot merged commit 469dd91 into swiftlang:master Feb 19, 2016
@practicalswift
Copy link
Contributor Author

@modocache Thank you! 😊

I can tackle the reverse case you mention, but before doing that I'd like @nadavrot:s approval of the idea so that such a PR stands a chance of being merged :-)

These are the remaining Python naming convention violations:

  • function name should be lowercase (57 instances)
  • argument name should be lowercase (16 instances)
  • variable in function should be lowercase (145 instances)

Which of those are okay to tackle? :-)

@nadavrot
Copy link
Contributor

@practicalswift I don't see a problem with any of these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants