[Python] Improve Python consistency: "variable in function should be lowercase" (N806) #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lowercase" (N806) The repo contains roughly 80 Python scripts. "snake_case" naming is used for local variables in all those scripts. This is the form recommended by the PEP 8 naming recommendations (Python Software Foundation) and typically associated with idiomatic Python code. However, in nine of the 80 scripts there were at least one instance of "camelCase" naming prior to this commit. This commit improves consistency in the Python code base by making sure that these nine remaining files follow the variable naming convention used for Python code in the project. References: * PEP 8: https://www.python.org/dev/peps/pep-0008/ * pep8-naming: https://pypi.python.org/pypi/pep8-naming
|
@modocache Do you have time to review? That would be appreciated! :-) |
|
Looks good to me, based on a quick scan through the source files. I'd merge this if CI passes! 💯 |
|
@swift-ci please test |
|
@modocache Thanks! Unfortunately I don't think commit access is a sufficient condition for being able to trigger @swift-ci :-) Seems like these commands can only be issued by Apple employees at the moment. |
|
@swift-ci Please test |
|
@practicalswift Yeah, I type in "@swift-ci please test" as a sort of bat signal for Apple org members to trigger CI for me. 😂 Thanks, @trentxintong! |
|
@jckarter please swift-ci |
modocache
added a commit
that referenced
this pull request
Mar 2, 2016
[Python] Improve Python consistency: "variable in function should be lowercase" (N806)
|
Thanks, @practicalswift! 💯 (Aside: I wish more of the Python code in |
MaxDesiatov
added a commit
that referenced
this pull request
Oct 19, 2020
Fix run filtering in nightly distribution script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Background
See discussion with @modocache and @nadavrot in #1369.
This is PR is part 3 of 3 in the series of PRs covering the Python naming consistency fixes discussed in #1369.
The previous parts were:
argument_name, see [Python] Argument names should be lowercase by convention #1374function_name(…), see [Python] Improve Python consistency: Use function_name(…) throughout (PEP8) #1399Rationale
The repo contains roughly 80 Python scripts.
snake_casenaming is used for local variables in all those scripts. This is the form recommended by the PEP 8 naming recommendations (Python Software Foundation) and typically associated with idiomatic Python code.However, in 11 of the 80 scripts there were at least one instance of
camelCasenaming prior to this commit.This commit improves consistency in the Python code base by making sure that these eleven remaining files also follow the variable naming convention used for Python code in the project.
References
Resolved bug number: –
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.