[SR 5641] Implement support for defer in the playground transform and PC macro. #13835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added handling of `defer` statements in the playground transform. Tests will be added in a follow-on commit. Patch by Roman Levenstein! This addresses SR-5641/<rdar://problem/33764082>.
As with the playground transform, defer statements were not supported in the PC macro. This commit addresses that oversight. This partially addresses <rdar://problem/29007242>.
|
@swift-ci Please test |
|
@jrose-apple Feel free to add alternate reviewers if someone else should look at this code too. |
jrose-apple
approved these changes
Jan 9, 2018
lib/Sema/PCMacro.cpp
Outdated
| DeferStmt *transformDeferStmt(DeferStmt *DS) { | ||
| if (auto *FD = DS->getTempDecl()) { | ||
| auto Implicit = FD->isImplicit(); | ||
| FD->setImplicit(false); |
There was a problem hiding this comment.
I don't love this hack, but I guess it's okay. Mind commenting why we have to do it, though?
| @@ -153,6 +155,17 @@ class Instrumenter : InstrumenterBase { | |||
| } | |||
| } | |||
|
|
|||
| DeferStmt *transformDeferStmt(DeferStmt *DS) { | |||
There was a problem hiding this comment.
…definitely a candidate for future refactoring up into InstrumenterBase.
|
@swift-ci Please smoke test and merge |
1 similar comment
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements handling of
deferstatements in both the playground transform and PC macro.Original patch for the playground transform provided by @swiftix.
Resolves SR-5641 and <rdar://problem/33764082>.