Skip to content

[5.0][SR 5641] Implement support for defer in the playground transform and PC macro. #14124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cwakamo
Copy link
Contributor

@cwakamo cwakamo commented Jan 24, 2018

Pulls the fix for SR-5641 from #13835 into swift-5.0-branch.

Resolves SR-5641/<rdar://problem/36765882>.

Added handling of `defer` statements in the playground transform.
Tests will be added in a follow-on commit.

Patch by Roman Levenstein!

This addresses SR-5641/<rdar://problem/33764082>.

(cherry picked from commit 0a9a4e7)
As with the playground transform, defer statements were not supported in the PC macro.
This commit addresses that oversight.

This partially addresses <rdar://problem/29007242>.

(cherry picked from commit 2c04058)
@cwakamo
Copy link
Contributor Author

cwakamo commented Jan 24, 2018

@swift-ci Please test and merge

@swift-ci swift-ci merged commit b040b4d into swiftlang:swift-5.0-branch Jan 24, 2018
@cwakamo cwakamo deleted the playground-transform-defer-statements-5.0 branch February 15, 2018 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants