IRGen: Empty fields do have an entry in the field offset vector #13904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an error introduced as the result of a refactoring a while ago and means that we will store dependently typed stored properties at the wrong offset in a generic struct if it has stored properties of empty types before said property. rdar://36384871
|
@eeckstein Can you review this for swift-4.1-branch? |
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
This was referenced Jan 12, 2018
|
The source compat failure in Kitura is the same that is also happening on master ATM here: https://ci.swift.org/job/swift-master-source-compat-suite/1068/artifact/swift-source-compat-suite/FAIL_Kitura_4.0_BuildSwiftPackage.log Not related to this patch. |
|
Reflection also relies on an accurate field offset vector. Does dump() work on a type with empty fields? |
|
@eeckstein Ping? |
|
@slavapestov swift displayed the contents wrong before this patch: |
|
Oh wait that is because it was wrongly set. |
|
@swift-ci Please test source compatibility |
eeckstein
reviewed
Jan 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an error introduced as the result of a refactoring a while ago
and means that we will store dependently typed stored properties at the
wrong offset in a generic struct if it has stored properties of empty
types before said property.
rdar://36384871