[4.1] IRGen: Empty fields do have an entry in the field offset vector

[aschwaighofer]

This is an error introduced as the result of a refactoring a while ago
and means that we will store dependently typed stored properties at the
wrong offset in a generic struct if it has stored properties of empty
types before said property.

Explanation: We would compute the wrong offset for dependently typed properties inside generic structs if said property was preceded by a stored property of empty type.

public struct GenericStruct<T : Proto> {
  var empty: EmptyStruct = EmptyStruct()
  var dummy: Int = 0
  var opt: Optional<T> = nil
}

Scope: This was introduced as the result of a refactoring in the swift-4.1-branch timeframe.

Risk: Low. Single line change that only applies to empty types when we compute their offset in the field offset vector.

Testing: Swift CI Tests added.

Reviewed by: Erik

rdar://36384871

[aschwaighofer]

@swift-ci Please test

[aschwaighofer]

@swift-ci Please test source compatibility

[aschwaighofer]

Master PR: #13904

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - bceabad

[aschwaighofer]

Oh, right old mangling on 4.1 ...

[aschwaighofer]

@swift-ci Please test

[aschwaighofer]

@swift-ci Please test source compatibility

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - bceabad

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - bceabad

[aschwaighofer]

The latest source compat suite run is here: https://ci.swift.org/view/Pull%20Request/job/swift-PR-source-compat-suite/559/

[aschwaighofer]

@swift-ci Please test

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - 22afda1

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - bceabad

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - 22afda1

[aschwaighofer]

@swift-ci Please test source compatibility

[aschwaighofer]

Latest SCS run here: https://ci.swift.org/view/Pull%20Request/job/swift-PR-source-compat-suite/567/

[aschwaighofer]

@swift-ci Please nominate

[aschwaighofer]

@swift-ci please nominate

[aschwaighofer]

@swift-ci nominate