[stdlib] Improve the flatMap deprecation message #14035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<rdar://problem/36555646>
|
@swift-ci Please smoke test |
|
I wonder whether it should read "this variant of flatMap is deprecated" |
|
That part comes from the compiler. It'd have to detect that there were other possible |
|
Oh right. I wonder if there’s any non-tortured phrasing to increase the clarity that it’s just this one not all flatmaps. But this might be as clear as we can get. |
|
I mean, please do file a JIRA, but it's probably not something we're going to prioritize. |
|
What I mean is, if there's another way to word our deprecation to somehow signal this. But I suspect there probably isn't, and let's take this in the meantime as it's definitely better than what we have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/36555646