[4.1][stdlib] Improve the flatMap deprecation message #14061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
moiseev
commented
Jan 22, 2018
moiseev
commented
- Explanation: The generic message generated by the compiler can be read as if all the versions of flatMap are being deprecated, whereas only one particular variant of it is, the one that accepts a closure returning an optional value.
- Scope of Issue: purely QoI, non-functional change, but is supposed to improve developer experience.
- Risk: Minimal
- Reviewed By: Ben Cohen
- Testing: Automated test suite with an updated test case for the new message
- Directions for QA: N/A
- Radar: rdar://problem/36555646
<rdar://problem/36555646> (cherry picked from commit aceb63e)
|
Similar to #14035 |
|
@swift-ci Please test |
|
@swift-ci Please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.