IRGen: fix a corner-case wherein a partial_apply was not converted in LoadableByAddress #14187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… LoadableByAddress It cleans up shouldTransformParameter, fixing a corner-case for optional function parameter, and re-creates *all* partial applies that only contain function/optional function parameters
|
@swift-ci Please smoke test |
shajrawi
changed the title
aschwaighofer
approved these changes
Jan 26, 2018
shajrawi
pushed a commit
that referenced
this pull request
Jan 26, 2018
IRGen: fix a corner-case wherein a partial_apply was not converted in LoadableByAddress
|
This broke with a non-optimized stdlib, https://ci.swift.org/view/Dashboard/job/oss-swift_tools-RA_stdlib-DA_test-simulator/177/. I'm going to disable the test in that configuration for now, but that seems like a bug—optimization shouldn't affect calling conventions here, no? |
|
Thanks for fixing that! It does call into the standard library, the array operation, for which the signature is different in an optimized build... |
|
It seems like you'd need to change the test anyway to deal with -enable-resilience. After all, the test will be permanently unsupported after that. |
shajrawi
pushed a commit
that referenced
this pull request
Jan 29, 2018
Merge pull request #14187 from shajrawi/fix_part_apply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/36826848
fix a corner-case wherein a partial_apply was not converted in LoadableByAddress
It also cleans up shouldTransformParameter, fixing a corner-case for optional function parameter, and re-creates all partial applies that only contain function/optional function parameters