Merge pull request #14187 from shajrawi/fix_part_apply #14194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
This is the mangling change between 4.1 and trunk. will change the tests accordingly. |
shajrawi
force-pushed
the
load_part_apply_cherry
branch
from
6d03654 to
61972f2
Compare
IRGen: fix a corner-case wherein a partial_apply was not converted in LoadableByAddress
shajrawi
force-pushed
the
load_part_apply_cherry
branch
from
61972f2 to
2dc2700
Compare
|
@swift-ci Please test |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/36826848
• Explanation: fixes a corner-case wherein a partial_apply was not converted in LoadableByAddress. It also cleans up shouldTransformParameter, fixing a corner-case for optional function parameter, and re-creates all partial applies that only contain function/optional function parameters
• Scope of Issue: We found this issue via JIRA - it can cause miscompiles in rare cases
• Origination: https://bugs.swift.org/browse/SR-6828
• Risk: Low.
• Reviewed By: Arnold Schwaighofer
• Testing: Swift CI + new test case