-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] Specialize floating-point constants for performance #14502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+66
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci Please test |
@swift-ci Please smoke benchmark |
Looks good, thanks. |
stephentyrone
approved these changes
Feb 9, 2018
Build comment file:Optimized (O)Regression (26)
Improvement (11)
No Changes (325)
Unoptimized (Onone)Regression (7)
Improvement (23)
No Changes (332)
Hardware Overview
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Floating-point constants such as
infinity
orgreatestFiniteMagnitude
can make one's code slower than necessary because they are computed each time they're used. By contrast,pi
is as fast as possible. Here, we follow the example ofpi
and speed up other constants.(In this PR,
signalingNaN
is deliberately untouched because it's got some interesting platform-specific behavior.)Resolves SR-6919.