[silgen] Make ensurePlusOne emit copies even when guaranteed normal a… #14571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rguments is not enabled. I want to use this to fix issues around us forwarding +0 values into memory. These fixes are good even from the perspective of normal compilation. rdar://34222540
|
This only introduces new copies where we didn't already have something at +1. |
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
@swift-ci test linux platform |
1 similar comment
|
@swift-ci test linux platform |
|
@swift-ci test source compatibility |
1 similar comment
|
@swift-ci test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rguments is not enabled.
I want to use this to fix issues around us forwarding +0 values into memory.
These fixes are good even from the perspective of normal compilation.
rdar://34222540
This fixes some of the issues in #14566 since I used ensurePlusOne to fix the exposed issues there
in emitForceInto.