[silgen] Require ManagedValue::{forward,assign}Into to only accept pl… #14566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
Build failed |
|
@swift-ci test os x platform |
|
Build failed |
gottesmm
force-pushed
the
pr-84f4d6b1f77131475b5abc2cd80f73ca6049bbaa
branch
from
eab7304 to
7b0204a
Compare
|
@swift-ci test |
|
@swift-ci source compatibility |
|
@swift-ci test source compatibility |
|
I am going to land the 3 sub patches in separate PRs and then commit only the last commit in this PR. It passed the source compat suite, so we should be ok. |
…usOne ManagedValues. We already have this requirement on RValues, so it is natural to extend it to ManagedValue. The main reason why I am doing this though is to tighten up SILGen asserts to help me catch places where we forward +0 arguments into memory without a copy/cleanup. rdar://34222540
gottesmm
force-pushed
the
pr-84f4d6b1f77131475b5abc2cd80f73ca6049bbaa
branch
from
7b0204a to
713e5f9
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci test source compatibility |
|
Build failed |
|
@swift-ci test source compatibility |
gottesmm
changed the title
|
1 word to say: WOOT! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…usOne ManagedValues.
We already have this requirement on RValues.
This also lets me clean up a little bit of code in RValue as well.