[+0-normal-args] When initializating an Any with trivial inline buffer contents, put a cleanup on the Any. #14641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r contents, put a cleanup on the Any. Otherwise, it looks like we are storing a non-trivial value (Any) to memory without a +1 cleanup, violating invariants. The change itself is harmless since destroying an Any containing only trivial things in the inline buffer is a no-op. This is the last change I need to enable the only +1 into memory assert. rdar://34222540
|
@swift-ci smoke test and merge |
|
Finally! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[+0-normal-args] When initializating an Any with trivial inline buffer contents, put a cleanup on the Any.
Otherwise, it looks like we are storing a non-trivial value (Any) to memory
without a +1 cleanup, violating invariants. The change itself is harmless since
destroying an Any containing only trivial things in the inline buffer is a
no-op.
This is the last change I need to enable the only +1 into memory assert.
rdar://34222540