[+0-normal-args] Use ManagedValues instead of SILValues in PatternMat… #14639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chEmission::emitSharedCaseBlocks(). This commit hoists the creation of ManagedValues earlier in the function. This ensures that the SILValues are never separated from their cleanups and allow us to pass ManagedValues that have proper cleanups to the forwardInto/assignInto API that is used herethe values into memory at +1. Previously, we would just drop the cleanup and forward the non-trivial value into memory without a cleanup, breaking invariants. Since it is just moving things earlier this is a pure /NFC/ change. As an extra benefit, this updates the code to use more modern SILGen. rdar://34222540
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…chEmission::emitSharedCaseBlocks().
This commit hoists the creation of ManagedValues earlier in the function. This
ensures that the SILValues are never separated from their cleanups and allow us
to pass ManagedValues that have proper cleanups to the forwardInto/assignInto
API that is used herethe values into memory at +1. Previously, we would just drop the
cleanup and forward the non-trivial value into memory without a cleanup,
breaking invariants. Since it is just moving things earlier this is a pure /NFC/
change.
As an extra benefit, this updates the code to use more modern SILGen.
rdar://34222540