build: explicitly state arch for ICU #14728
Conversation
|
@swift-ci please test |
|
Build failed |
This is needed to support cross-compilation on targets which do not support FAT binaries (i.e. non-MachO targets). The primary user of this functionality right now is Windows, but this support is needed for Linux and android as well.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test Linux platform |
|
@compnerd I don't remember how all of this fits together (I would have to review/page in the code again). @Rostepher any thoughts? |
|
@gottesmm this basically creates a ton more cached CMake values to specify the ICU libraries for each (os, arch) pair. This enables multiple cross-compiled builds for non-MachO targets which do not have FAT binaries. It effectively changes the naming pattern for the variables. |
|
@gottesmm what do you think of merging this? This is really needed to get the Windows cross-compilation story fixed up. |
|
I see what you did. It looks overall good. Can you double check that you caught all ICU checks? |
|
@gottesmm pretty sure that I have got all the sites covered here |
|
Then led er rip |
This is needed to support cross-compilation on targets which do not
support FAT binaries (i.e. non-MachO targets). The primary user of this
functionality right now is Windows, but this support is needed for Linux
and android as well.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.