Skip to content

Change the linking of icu in libswiftCore to use icu-config instead of simply adding via an -l flag in order to capture the correct path #14801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

lanza
Copy link
Contributor

@lanza lanza commented Feb 23, 2018

Using -licuXYZ on the command line selects whatever version shows up first in the search path. In the case of CentOS we have /usr/lib/libicuXYZ.so.50 being chosen which is not compatible with Swift. Using icu-config allows the user installed icu variants to take priority.

Requires
#14734
#14728

…f simply adding via an -l flag in order to capture the correct path
@lanza
Copy link
Contributor Author

lanza commented Feb 23, 2018

@compnerd

@jrose-apple
Copy link
Contributor

This is a CMake file, not a shell script.

@compnerd
Copy link
Member

ICU_UC ICU_I18N should be setup properly by the user. This is setup in build-script-impl IIRC. We shouldn't be using unix specific shell constructs in CMake.

@lanza lanza closed this Feb 28, 2018
@lanza lanza deleted the core.icuconfig branch March 13, 2018 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants