stubs: match ICU signature for unorm2_normalize (NFC) #14734
Conversation
|
@swift-ci please test and merge |
|
@milseman suggestion on how to deal with this API change? Seems that older revisions used a different signature. |
|
I have no idea why this decl even changed. @lancep do you know? |
|
Because I was hitting the same failure that this just hit |
|
So it seems That builder is using ICU-55 (ancient). Long term, we're considering just bundling an ICU with Swift on Linux instead of using Ubuntu's pre-Swift versions of ICU. edit: We could try to condition it based on http://icu-project.org/apiref/icu4c/uvernum_8h.html#a3f14ba8e1513e47458e2b285d777529a. The issue is that the shim header doesn't necessarily have access to this. We might want to define an ICU_VERSION which we set to 55 on old Ubuntu |
|
@milseman how about being absolutely unhygienic here? Technically, the signature is compatible, the difference is that we use a well specified type rather than an underspecified type. We could do a |
|
I'm fine with utterly unhygienic solutions for back-compat with old ICUs, preferably with the unsanitary parts touching the old and not the new. |
compnerd
force-pushed
the
icu-signature
branch
from
b60cfc4 to
cbef5a9
Compare
|
@swift-ci please test and merge |
Adjust the signature to match the ICU declaration for `unorm2_normalize`. This was adjusted to allow building against ICU 59.1. The shim type definition for the UChar ensures that the signature is correct on all the targets. NFC.
compnerd
force-pushed
the
icu-signature
branch
from
cbef5a9 to
73c04d1
Compare
|
@swift-ci please test and merge |
Adjust the signature to match the ICU declaration for
unorm2_normalize. This was adjusted to allow building against ICU59.1. The shim type definition for the UChar ensures that the signature
is correct on all the targets. NFC.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.