Devirtualizer: disable the “effectively final” optimization if a function is inlinable #14740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion is inlinable. The devirtualizer performs two optimizations: - If a value is known to have an exact class type, ie it is the result of an alloc_ref, we can devirtualize calls of *non-final* methods, because we know we’re calling that specific method and not an override. - If a method is known to be “effectively final” (it is not open, and there are no overrides inside the module) we can devirtualize it. However the second optimization needs to be disabled if a function is inlinable (F->getResilienceExpansion() == ResilienceExpansion::Minimal).
|
@swift-ci Please test and merge |
shajrawi
pushed a commit
to shajrawi/swift
that referenced
this pull request
Jun 19, 2018
…ller is serialized Improve the check done in swiftlang#14740 The class_method being devirtualized might be OK for most call sites, i.e. we are allowed to devirtualize it, however, the caller itself might have been marked with inlinable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
radar rdar://problem/36703886
The devirtualizer performs two optimizations:
If a value is known to have an exact class type, ie it is the result of an alloc_ref, we can devirtualize calls of non-final methods, because we know we’re calling that specific method and not an override.
If a method is known to be “effectively final” (it is not open, and there are no overrides inside the module) we can devirtualize it.
However the second optimization needs to be disabled if a function is inlinable
(F->getResilienceExpansion() == ResilienceExpansion::Minimal).