Devirtualizer: disable the “effectively final” optimization if the caller is serialized #17327
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ller is serialized Improve the check done in swiftlang#14740 The class_method being devirtualized might be OK for most call sites, i.e. we are allowed to devirtualize it, however, the caller itself might have been marked with inlinable
|
@swift-ci Please smoke test and merge |
jrose-apple
reviewed
Jun 19, 2018
| @@ -516,7 +516,9 @@ bool swift::canDevirtualizeClassMethod(FullApplySite AI, | |||
|
|
|||
| // We need to disable the “effectively final” opt if a function is inlinable | |||
| if (isEffectivelyFinalMethod && | |||
| F->getResilienceExpansion() == ResilienceExpansion::Minimal) { | |||
| ((F->getResilienceExpansion() == ResilienceExpansion::Minimal) || | |||
There was a problem hiding this comment.
Is the first check even necessary? It seems like this is always about the call site. cc @slavapestov
There was a problem hiding this comment.
I agree with @jrose-apple. It's always OK to inline an inlinable function into a non-inlinable function.
There was a problem hiding this comment.
Removed the first check: #17337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/41106812
Improve the check done in #14740
The class_method being devirtualized might be OK for most call sites, i.e. we are allowed to devirtualize it, however, the caller itself might have been marked with inlinable