[build-script] Updated build-script-impl to be able to run the tests … #14821
Conversation
|
Please test with the following PRs: apple/swift-xcode-playground-support#23 @swift-ci Please test |
|
Build failed |
|
The failure matches what I've seen locally… I believe the issue is that the cast in PlaygroundLogger to |
…for the new PlaygroundLogger. Switched to using `build-for-testing`/`test-without-building` for the PlaygroundLogger tests. The new PlaygroundLogger tests are now a proper XCTest unit test bundle, so it needs to be done this way (instead of building the test runner and then just invoking that). This is part of <rdar://problem/37765445>.
cwakamo
force-pushed
the
update-build-script-for-new-PlaygroundLogger
branch
from
fbd9a90 to
5d8b6ad
Compare
|
Please test with the following PRs: apple/swift-xcode-playground-support#23 @swift-ci Please test |
|
Build failed |
|
Please test with the following PRs: apple/swift-xcode-playground-support#23 @swift-ci Please test |
|
Please build with the following PRs: apple/swift-xcode-playground-support#23 @swift-ci Please Build Toolchain macOS Platform |
|
macOS Toolchain Install command |
|
The toolchain has all of the content I would expect, and all of the tests for the new PlaygroundLogger ran and passed, so I think this PR plus apple/swift-xcode-playground-support#23 are ready to land. @Rostepher @zisko If one of you could review this minor build-script change, that would be great! Assuming this looks good I also plan on making this change on swift-4.2-branch so I can likewise pull the new PlaygroundLogger implementation into swift-xcode-playground-support's swift-4.2-branch. (And thanks @jrose-apple for adding them as reviewers -- I hadn't added anyone yet as I wanted to make sure everything worked as expected in CI.) |
|
Ah, got it. I won't jump ahead next time! |
…for the new PlaygroundLogger.
Switched to using
build-for-testing/test-without-buildingfor the PlaygroundLogger tests.The new PlaygroundLogger tests are now a proper XCTest unit test bundle, so it needs to be done this way (instead of building the test runner and then just invoking that).
This depends on the changes in apple/swift-xcode-playground-support#23, which replaces the PlaygroundLogger framework with a brand-new implementation.
This is part of rdar://problem/37765445.