Skip to content

[4.2] [build-script] Updated build-script-impl to be able to run the tests for the new PlaygroundLogger. #17861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

cwakamo
Copy link
Contributor

@cwakamo cwakamo commented Jul 10, 2018

Switched to using build-for-testing/test-without-building for the PlaygroundLogger tests.
The new PlaygroundLogger tests are now a proper XCTest unit test bundle, so it needs to be done this way (instead of building the test runner and then just invoking that).

This pulls the changes for #14821 into swift-4.2-branch, and it depends on apple/swift-xcode-playground-support#28.

This is part of rdar://problem/41868882.

…for the new PlaygroundLogger.

Switched to using `build-for-testing`/`test-without-building` for the PlaygroundLogger tests.
The new PlaygroundLogger tests are now a proper XCTest unit test bundle, so it needs to be done this way (instead of building the test runner and then just invoking that).

This is part of <rdar://problem/41868882>.
@cwakamo
Copy link
Contributor Author

cwakamo commented Jul 10, 2018

Please test with the following PR:

apple/swift-xcode-playground-support#28

@swift-ci Please test

@cwakamo
Copy link
Contributor Author

cwakamo commented Jul 11, 2018

Please build with the following PRs:

apple/swift-xcode-playground-support#28

@swift-ci Please Build Toolchain macOS Platform

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - c347ea9

Install command
tar -zxf swift-PR-17861-48-osx.tar.gz --directory ~/

@cwakamo cwakamo requested review from Rostepher and zisko July 11, 2018 15:02
@cwakamo
Copy link
Contributor Author

cwakamo commented Jul 11, 2018

@zisko @Rostepher If one of y'all wouldn't mind re-reviewing this patch for Swift 4.2 nomination, I'd greatly appreciate it!

Copy link
Contributor

@zisko zisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cwakamo
Copy link
Contributor Author

cwakamo commented Jul 18, 2018

• Explanation: This PR adds support for building and testing the new PlaygroundLogger implementation in apple/swift-xcode-playground-support#28. This will allow the PlaygroundLogger in Swift 4.2 to, among other things, include support for CustomPlaygroundDisplayConvertible.
• Scope of Issue: Affects how build-script builds and runs the tests for PlaygroundLogger. Should not impact Swift itself.
• Risk: Low, may cause temporary build instability as this and apple/swift-xcode-playground-support#28 land
• Testing: Ran PR testing and observed no regressions. Additionally, used PR testing to produce a macOS toolchain and observed that it contained the correct content.

@cwakamo cwakamo merged commit cae57f4 into swiftlang:swift-4.2-branch Jul 19, 2018
@cwakamo cwakamo deleted the update-build-script-for-new-PlaygroundLogger-4.2 branch July 19, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants