Skip to content

[SILGen] Use shared string constant for swift shims name in SILPrint #14959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2018
Merged

[SILGen] Use shared string constant for swift shims name in SILPrint #14959

merged 1 commit into from
Mar 3, 2018

Conversation

kitasuke
Copy link
Contributor

@kitasuke kitasuke commented Mar 3, 2018 •
edited
Loading

It used to be "SwiftShims", but it would be better to use SWIFT_SHIMS_NAME defined in String.h instead in my opinion.

@gottesmm
Copy link
Contributor

gottesmm commented Mar 3, 2018

LGTM

@gottesmm
Copy link
Contributor

gottesmm commented Mar 3, 2018

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit 95e1558 into swiftlang:master Mar 3, 2018
rintaro
rintaro reviewed Mar 4, 2018
View reviewed changes
lib/SIL/SILPrinter.cpp
@@ -2634,7 +2634,7 @@ void SILModule::print(SILPrintContext &PrintCtx, ModuleDecl *M,
}

OS << "\n\nimport Builtin\nimport " << STDLIB_NAME
Copy link
Member

@rintaro rintaro Mar 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kitasuke Let's make BUILTIN_NAME for "Builtin" as well. It's also used in AST.

@kitasuke kitasuke mentioned this pull request Mar 4, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rintaro rintaro rintaro left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kitasuke @gottesmm @rintaro @swift-ci