Skip to content

[SILGen] Use shared string constant for swift shims name in SILPrint #14959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2018
Merged

[SILGen] Use shared string constant for swift shims name in SILPrint #14959

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/SIL/SILPrinter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2634,7 +2634,7 @@ void SILModule::print(SILPrintContext &PrintCtx, ModuleDecl *M,
}

OS << "\n\nimport Builtin\nimport " << STDLIB_NAME
Copy link
Member

@rintaro rintaro Mar 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kitasuke Let's make BUILTIN_NAME for "Builtin" as well. It's also used in AST.

<< "\nimport SwiftShims" << "\n\n";
<< "\nimport " << SWIFT_SHIMS_NAME << "\n\n";

// Print the declarations and types from the associated context (origin module or
// current file).
Expand Down