[stdlib] Move DoubleWidth to test/Prototypes #15470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 23, 2018 15:42
The implementation uses DoubleWidth<T> that needs to be removed due to library binary size issues. Even extracting the single DoubleWidth method that's used in it would likely result in having to copy a large portion of the rest of DoubleWidth implementation along with it, this defeating the purpose. This change restores the behavior of dividingFullWidth as it was shipped with Swift 4.1, therefore it's not a breaking change.
|
@swift-ci Please smoke test |
|
Why is that? |
|
cos it generates binaries the size of a humpback whale... |
|
We need to set aside time to figure out why and fix that underlying problem. Meanwhile it can stay testing in Prototypes ready to move back once we do. |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is with deep regret and profound sadness that I have to do this. Our beloved type
DoubleWIdththat served as a witness of usefulness of the new integer protocols has to move from being a part of the standard library to a mere prototype.