[Batch mode] Warn the user if -enable-batch-mode gets overridden by -whole-module-optimization or -index-file. #15578
+55
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidungar
force-pushed
the
PR-19-warn-WMO-batch
branch
4 times, most recently
from
8230f4d to
57baf2e
Compare
|
@swift-ci please smoke test |
davidungar
requested review from
graydon,
anemet and
jrose-apple
and removed request for
anemet
jrose-apple
approved these changes
Mar 28, 2018
graydon
approved these changes
Mar 29, 2018
lib/Driver/Driver.cpp
Outdated
| if (!ArgRequiringWMO) | ||
| return OutputInfo::Mode::StandardCompile; | ||
|
|
||
| // Test for -explicit-batch-mode, rather than the BatchMode flag that is |
There was a problem hiding this comment.
s/-explicit-batch-mode/-enable-batch-mode/
|
@swift-ci please smoke test linux platform |
davidungar
force-pushed
the
PR-19-warn-WMO-batch
branch
from
57baf2e to
43b8913
Compare
|
@swift-ci please smoke test |
davidungar
pushed a commit
to davidungar/swift
that referenced
this pull request
Mar 29, 2018
[Batch mode] Warn the user if -enable-batch-mode gets overridden by -whole-module-optimization or -index-file.
davidungar
pushed a commit
that referenced
this pull request
Mar 30, 2018
…oring-batch-mode-swift-4.2-branch [Batch mode] Merge pull request #15578 from davidungar/PR-19-warn-WMO-batch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user could get confused because the compiler won't run in batch mode, even if given the
-enable-batch-modecommand line option if it is also given either-whole-module-optimizationor-index-file.rdar://problem/38924422