[Batch mode] Merge pull request #15578 from davidungar/PR-19-warn-WMO-batch #15606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Batch mode] Warn the user if -enable-batch-mode gets overridden by -whole-module-optimization or -index-file.
|
@swift-ci please test |
|
@swift-ci please nominate |
davidungar
deleted the
rdar-39012584-warn-when-ignoring-batch-mode-swift-4.2-branch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Batch mode] Warn the user if -enable-batch-mode gets overridden by -whole-module-optimization or -index-file.
Explanation: Issue a warning to prevent confusion when the compiler ignores -enable-batch-mode because of either -whole-module-optimization or -index-file.
Scope of Issue: Users trying out batch mode will think it does no good because the compiler silently ignores their requests.
Origination: Issue has existed since we implemented batch mode.
Risk: Minimal, because only functional change is a warning. There is a tiny bit of refactoring, which has been carefully reviewed.
Reviewed by: Jordan Rose & Graydon Hoare.
Testing: Normal regression tests + this PR includes a new test of the new functionality
Radar: rdar://39012584