Make 'rawValue' and 'init(rawValue:)' inlinable for non-resilient enums #15589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still needs tests, but I want to see if this happens to improve any benchmarks. (The JIRA has an ad hoc benchmark that could probably be added to the suite too.) |
|
@swift-ci Please benchmark |
slavapestov
reviewed
Mar 29, 2018
| @@ -146,6 +146,11 @@ static VarDecl *deriveRawRepresentable_raw(TypeChecker &tc, | |||
| addGetterToReadOnlyDerivedProperty(tc, propDecl, rawType); | |||
| getterDecl->setBodySynthesizer(&deriveBodyRawRepresentable_raw); | |||
|
|
|||
| if (enumDecl->isExhaustive(nullptr) && | |||
| enumDecl->getFormalAccessScope(nullptr, true).isPublic()) { | |||
There was a problem hiding this comment.
Can you add a comment like /* respectsVersioned */ true?
slavapestov
approved these changes
Mar 29, 2018
There was a problem hiding this comment.
Looks good. We can do the same for equatable and hashable as well, however last time I looked the synthesized code for the no-payload case was really inefficient with switching over the tag when it could just bitcast the enum value to an integer and compare for equality. Anyway no need to investigate this in your PR.
Build comment file:Optimized (O)Regression (24)
Improvement (7)
No Changes (394)
Unoptimized (Onone)Regression (8)
Improvement (5)
No Changes (412)
Hardware Overview |
|
Uh, interesting. Maybe things are getting inlined now where it would be better not to. This change also isn't 100% resilient because in theory you could decide |
eeckstein
approved these changes
Mar 29, 2018
|
Okay, I've thought about this more and:
which I think means finding all of the examples in the stdlib where it matters and hand-rolling @slavapestov, thoughts? |
|
Further discovery: there is exactly one enum in the entire stdlib that would benefit from this: FloatingPointSign (the original cause of the bug). I think I'm going to just implement the synthesized members for that and punt on the original question (EDIT) for resilient libraries. |
|
Did that in #16043. Going to update this PR to only add |
Small potential perf win...or rather regain, since we apparently used to do this. It's a bit trickier to say whether we should do the same for resilient enums, since /in theory/ a later version of the library might decide to use different raw values. https://bugs.swift.org/browse/SR-7094
jrose-apple
changed the title
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test compiler performance |
|
Build failed |
|
Build failed |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Apr 21, 2018
…ms (swiftlang#15589) Small potential perf win...or rather regain, since we apparently used to do this. It's a bit trickier to say whether we should do the same for resilient enums, since /in theory/ a later version of the library might decide to use different raw values. https://bugs.swift.org/browse/SR-7094 (cherry picked from commit 766acd4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(
includingonly enums in libraries compiled without -enable-resilience)Small potential perf win...or rather regain, since we apparently used to do this.
SR-7094 / rdar://problem/38030106