[4.2] Two @inlinable rawValue optimizations #16082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ftlang#16043) The compiler can synthesize these, but it doesn't mark them @inlinable, since in the general case they're just a "default" implementation and not "the only implementation forever". But for a two-element enum that's based on a part of IEEE 754, it's probably safe to assume this is the only implementation forever, and that can be important for performance. https://bugs.swift.org/browse/SR-7094 (cherry picked from commit f6b67f3)
…ms (swiftlang#15589) Small potential perf win...or rather regain, since we apparently used to do this. It's a bit trickier to say whether we should do the same for resilient enums, since /in theory/ a later version of the library might decide to use different raw values. https://bugs.swift.org/browse/SR-7094 (cherry picked from commit 766acd4)
jrose-apple
changed the title
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimizations that just missed the branch (#16043 and #15589), both reviewed by @slavapestov. We still have more work to do on the original bug SR-7094, and I also filed some extra Radars to discuss whether to expand this to more synthesized declarations.