Remove almost all remaining uses of DeclChecker::IsFirstPass #15703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
Build failed |
We can use the existing logic for checking recursion in declaration validation. This eliminates some bogus diagnostics and allows some weird logic to be removed from typo correction.
With the previous changes, validating a property while type checking its initializer is no longer a fatal error. This means we don't have to do anything special when validating typo correction candidates, so we can get rid of the TypoCorrectionResolver. This means there is now only one subclass of LazyResolver, the TypeChecker itself.
Also kill a usage of IsFirstPass.
slavapestov
force-pushed
the
decl-checker-cleanup-part-4
branch
from
03341c2 to
b4f2324
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #15453. Also simplifies some weird logic in typo correction that was meant to get around circular validation problems in a hacky way.