Skip to content

Remove even more usages of DeclChecker::IsFirstPass #15729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

slavapestov
Copy link
Contributor

Follow-up to #15703. Now, we add function bodies to the 'to be typechecked' list in the first pass.

@slavapestov slavapestov force-pushed the decl-checker-cleanup-part-5 branch from c4106f4 to dbd8468 Compare April 4, 2018 05:53
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

If the base class initializer was '@inlinable public' and the
derived class was '@usableFromInline internal', the synthesized
initializer was '@inlinable internal', which was an error.
@slavapestov slavapestov force-pushed the decl-checker-cleanup-part-5 branch from dbd8468 to 8fe9df4 Compare April 4, 2018 07:08
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Apr 4, 2018

Build failed
Swift Test Linux Platform
Git Sha - c4106f457a9a3e2ba2c9615ea9f4c62958606036

@swift-ci
Copy link
Contributor

swift-ci commented Apr 4, 2018

Build failed
Swift Test OS X Platform
Git Sha - c4106f457a9a3e2ba2c9615ea9f4c62958606036

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov slavapestov merged commit a1eb1fe into swiftlang:master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants