Nuke DeclChecker::IsFirstPass #15731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
approved these changes
Apr 4, 2018
| @@ -527,11 +528,6 @@ static void typeCheckFunctionsAndExternalDecls(SourceFile &SF, TypeChecker &TC) | |||
| for (AbstractFunctionDecl *FD : TC.definedFunctions) { | |||
| TC.checkFunctionErrorHandling(FD); | |||
| } | |||
| for (auto decl : TC.Context.ExternalDefinitions) { | |||
| if (auto fn = dyn_cast<AbstractFunctionDecl>(decl)) { | |||
| TC.checkFunctionErrorHandling(fn); | |||
lib/Sema/TypeChecker.cpp
Outdated
| @@ -462,6 +462,18 @@ static void typeCheckFunctionsAndExternalDecls(SourceFile &SF, TypeChecker &TC) | |||
| TC.finalizeDecl(decl); | |||
| } | |||
|
|
|||
| // Type check conformance contexts. | |||
| for (unsigned i = 0; i != TC.ConformanceContexts.size(); ++i) { | |||
There was a problem hiding this comment.
Good choice; I like doing this as a later "pass" anyway at this point, because it makes us less likely to be order-sensitive in the interim.
slavapestov
force-pushed
the
decl-checker-cleanup-part-6
branch
3 times, most recently
from
0ade261 to
ec5946c
Compare
slavapestov
force-pushed
the
decl-checker-cleanup-part-6
branch
from
ec5946c to
6f79c2f
Compare
I tried doing this directly from typeCheckDecl(), but it breaks associated type inference. We can figure this out later when declaration checking becomes lazier and more incremental. Note that typo correction does not force witnesses of synthesized conformances. This means that a typo correction from a top-level form will no longer pick up synthesized witnesses, and will find the protocol requirement instead. To give a test the same behavior as before, I put the expression in a function body instead of a top-level form. Note that we already had the same behavior with typo correction from pattern binding initializers and other contexts that are type checked before conformances.
slavapestov
force-pushed
the
decl-checker-cleanup-part-6
branch
from
6f79c2f to
5e4f5a4
Compare
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
2 similar comments
|
@swift-ci Please test source compatibility |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The epic season finale of #15729.