[DebugInfo] Set the autogenerated bit to request recycled locations #15929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a default location of None doesn't seem to enhance readability.
IRGenDebugInfo expects to see an autogenerated bit before allowing reuse of the last seen debug location for a new instruction. rdar://28544248
|
@swift-ci Please smoke test |
adrian-prantl
approved these changes
Apr 13, 2018
lib/IRGen/IRGenDebugInfo.cpp
Outdated
| @@ -125,7 +125,7 @@ class IRGenDebugInfoImpl : public IRGenDebugInfo { | |||
| void finalize(); | |||
|
|
|||
| void setCurrentLoc(IRBuilder &Builder, const SILDebugScope *DS, | |||
| Optional<SILLocation> Loc = None); | |||
| Optional<SILLocation> Loc); | |||
There was a problem hiding this comment.
Is there a caller left that actually passes None? Otherwise we could drop the Optional.
There was a problem hiding this comment.
Good call, I'll do that.
Passing in some SILLocation to IRGenDebugInfo setCurrentLoc() will now be mandatory.
|
@swift-ci Please smoke test and merge |
1 similar comment
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRGenDebugInfo expects to see an autogenerated bit before allowing reuse
of the last seen debug location for a new instruction.
rdar://28544248