Skip to content

Revert "[DebugInfo] Set the autogenerated bit to request recycled locations" #15941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2018

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Apr 15, 2018

Reverts #15929

This breaks PR testing because it was only smoke tested.

/swift/test/DebugInfo/returnlocation.swift:188:22: error: CHECK_INIT-NEXT: is not on the line after the previous match
 // CHECK_INIT-NEXT: call void @swift_bridgeObjectRelease{{.*}}, !dbg [[retnLoc:![0-9]+]]
                     ^
<stdin>:752:2: note: 'next' match was here
 call void @swift_bridgeObjectRelease(%swift.bridge* %2) #4, !dbg !275
 ^
<stdin>:749:149: note: previous match ended here
 call swiftcc void @"$Ss5print_9separator10terminatoryypd_S2StF"(%swift.bridge* %2, i32 %16, i32 %17, i32 %18, i32 %20, i32 %21, i32 %22), !dbg !274
                                                                                                                                                    ^
<stdin>:750:1: note: non-matching line after previous match is here
 call void @"$Ss13_StringObjectV8_VariantOWOe"(i32 %20), !dbg !275
^

https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RD_test-simulator/869/consoleFull#174822253ba62d58e-7248-467b-91e0-c7508d5cf947

@atrick
Copy link
Contributor Author

atrick commented Apr 15, 2018

@swift-ci test.

@atrick atrick requested a review from vedantk April 15, 2018 01:53
@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 53a0676

@atrick
Copy link
Contributor Author

atrick commented Apr 15, 2018

Reverting this is blocked by PR #15930.

@atrick
Copy link
Contributor Author

atrick commented Apr 15, 2018

@swift-ci smoke test OS X Platform.

@atrick
Copy link
Contributor Author

atrick commented Apr 15, 2018

@swift-ci test.

@atrick atrick merged commit e3402bf into master Apr 15, 2018
@vedantk
Copy link
Contributor

vedantk commented Apr 16, 2018

Sorry about this. There should be a simpler way to write this test.

@atrick atrick deleted the revert-15929-retn-loc branch November 14, 2018 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants