IRGen: Correctly indicate non-key same-typed generic parameters. #15984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…redRequirements`. Fixes a bug where having two generic params same-typed together would lead to crashes in IRGen, and maybe other places, that only expect to deal with canonical params.
The correct query here is whether the generic parameter is canonical within its generic signature, not whether it's concrete.
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
DougGregor
approved these changes
Apr 17, 2018
|
Looks good, but an execution test would be nice too! |
|
@slavapestov I've got an execution test coming along with the bug I'm really trying to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct query here is whether the generic parameter is canonical within its generic signature, not whether it's concrete.
(Note that this includes the patches from #15960, since without that fix this ends up crashing in IRGen elsewhere.)