[Sema] Ensure that NameAliasTypes record the right substitutions. #16172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a typealias is inside a protocol, and things are defined in a certain order, the NameAliasType for that typealias can be constructed before the parent protocol has been validated (i.e. before its generic environment exists), in which case it is missing the necessary substitutions. Fixes rdar://problem/39636312.
DougGregor
approved these changes
Apr 26, 2018
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
slavapestov
reviewed
Apr 27, 2018
| // propagates to the typealias, since the former may not have existed when | ||
| // the typealiases type was first computed. | ||
| // FIXME: See the comment in the ProtocolDecl case of validateDecl(). | ||
| tc.validateDecl(protocol); |
There was a problem hiding this comment.
What happens if you just unconditionally call validateDecl() and remove the validateDeclForNameLookup() call above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a typealias is inside a protocol, and things are defined in a certain order,
the NameAliasType for that typealias can be constructed before the parent
protocol has been validated (i.e. before its generic environment exists), in
which case it is missing the necessary substitutions.
Fixes rdar://problem/39636312.