Skip to content

[4.2] [Sema] Ensure that NameAliasTypes record the right substitutions. #16203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2018
Merged

[4.2] [Sema] Ensure that NameAliasTypes record the right substitutions. #16203

merged 1 commit into from
Apr 27, 2018

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Apr 27, 2018

@huonw
[Sema] Ensure that NameAliasTypes record the right substitutions.
6db683c 
If a typealias is inside a protocol, and things are defined in a certain order,
the NameAliasType for that typealias can be constructed before the parent
protocol has been validated (i.e. before its generic environment exists), in
which case it is missing the necessary substitutions.

Fixes rdar://problem/39636312.
@huonw
Copy link
Contributor Author

huonw commented Apr 27, 2018

@swift-ci please smoke test

@huonw
Copy link
Contributor Author

huonw commented Apr 27, 2018

@swift-ci please test

@huonw huonw merged commit 817554b into swiftlang:swift-4.2-branch Apr 27, 2018
@huonw huonw deleted the protocol-typealias-crash-4.2 branch April 27, 2018 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@huonw