Skip to content

[Sema] Diagnose redundant conditional conformances more specifically. #16201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2018

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Apr 27, 2018

We don't allow things like

extension Type: P where Param: P {}
extension Type: P where Param: Q {}

or

extension Type: P where Param == Int {}
extension Type: P where Param == Float {}

or

extension Type: P where Param: P {}
extension Type: P where Param == SomethingThatIsntP {}

and the default error message "redundant conformance" message doesn't convey
this very well.

Fixes rdar://problem/36262409.

We don't allow things like

    extension Type: P where Param: P {}
    extension Type: P where Param: Q {}

or

    extension Type: P where Param == Int {}
    extension Type: P where Param == Float {}

or

    extension Type: P where Param: P {}
    extension Type: P where Param == SomethingThatIsntP {}

and the default error message "redundant conformance" message doesn't convey
this very well.

Fixes rdar://problem/36262409.
@huonw
Copy link
Contributor Author

huonw commented Apr 27, 2018

@swift-ci please smoke test

@huonw huonw merged commit 59bcbb3 into swiftlang:master Apr 30, 2018
@huonw huonw deleted the overlapping-conditional-conformances branch April 30, 2018 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant