Skip to content

[4.2] [Sema] Diagnose redundant conditional conformances more specifically. #16247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2018
Merged

[4.2] [Sema] Diagnose redundant conditional conformances more specifically. #16247

merged 1 commit into from
Apr 30, 2018

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Apr 30, 2018

@huonw
[Sema] Diagnose redundant conditional conformances more specifically.
52fa44d 
We don't allow things like

    extension Type: P where Param: P {}
    extension Type: P where Param: Q {}

or

    extension Type: P where Param == Int {}
    extension Type: P where Param == Float {}

or

    extension Type: P where Param: P {}
    extension Type: P where Param == SomethingThatIsntP {}

and the default error message "redundant conformance" message doesn't convey
this very well.

Fixes rdar://problem/36262409.
@huonw
Copy link
Contributor Author

huonw commented Apr 30, 2018

@swift-ci please test

@huonw
Copy link
Contributor Author

huonw commented Apr 30, 2018

@swift-ci please test OS X platform

@huonw huonw merged commit 565abe4 into swiftlang:swift-4.2-branch Apr 30, 2018
@huonw huonw deleted the overlapping-conditional-conformances-4.2 branch April 30, 2018 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@huonw