Skip to content

[GSB] Don't try to infer requirements from error types. #16274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

huonw
Copy link
Contributor

@huonw huonw commented May 1, 2018

Fixes rdar://problem/39548143.

@huonw
Copy link
Contributor Author

huonw commented May 1, 2018

@swift-ci please smoke test

@huonw
Copy link
Contributor Author

huonw commented May 1, 2018

Arguably it's fundamentally incorrect to have a NameAliasType with no SubstitutionMap, so maybe I should instead go fix that there (and/or hope #16268 helps).

@huonw huonw requested a review from DougGregor May 1, 2018 02:14
@shahmishal
Copy link
Member

@swift-ci please smoke test

@huonw
Copy link
Contributor Author

huonw commented May 1, 2018

Oh, nevermind, the problem is something different: the NameAliasType is theoretically behaving correctly here, as getSubstitutionListSize() for its generic signature returns 0, meaning the type doesn't store any substitutions and the map is empty. It does seem as if #16268 is very relevant to this misbehaviour.

@huonw huonw closed this May 1, 2018
@huonw huonw deleted the rdar39548143 branch May 1, 2018 06:58
@huonw
Copy link
Contributor Author

huonw commented May 1, 2018

It does seem as if #16268 is very relevant to this misbehaviour.

In fact, it fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants