Skip to content

[4.2] Just autolink everything #16390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 5, 2018
Merged

[4.2] Just autolink everything #16390

merged 2 commits into from
May 5, 2018

Conversation

jrose-apple
Copy link
Contributor

Cherry-pick of the non-reverty parts of #16349 to the 4.2 branch. Reviewed by @graydon and @DougGregor.

rdar://problem/39338239

jrose-apple added 2 commits May 4, 2018 13:00
@jrose-apple
[test] Make sure to use the mock SDK overlays for these IRGen tests
da9aa1d 
And disable them on non-ObjC platforms again, because those overlays
depend on a stdlib that contains _ObjectiveCBridgeable.

(cherry picked from commit 0e5100d)
@jrose-apple
Just autolink every imported module, public or private
6bec6d8 
This is unfortunate in that it makes the linker do extra work, but in
practice it probably doesn't matter much, and meanwhile it handles all
our problems with @inlinable.

Alternate solution to rdar://problem/39338239

(cherry picked from commit 098b170)
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test source compatibility

@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test compiler performance

@jrose-apple jrose-apple mentioned this pull request May 4, 2018
Merged
@swift-ci
Copy link
Contributor

swift-ci commented May 4, 2018

Build failed
Swift Test OS X Platform
Git Sha - 274598d5c1f31ce90e6cd801e79fce9e32b0296c

@swift-ci
Copy link
Contributor

swift-ci commented May 4, 2018

Build failed
Swift Test Linux Platform
Git Sha - 274598d5c1f31ce90e6cd801e79fce9e32b0296c

@jrose-apple jrose-apple force-pushed the 4.2-just-autolink-everything branch from 274598d to 6bec6d8 Compare May 4, 2018 20:30
@jrose-apple
Copy link
Contributor Author

@swift-ci Please test

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test source compatibility

@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test compiler performance

@swift-ci
Copy link
Contributor

swift-ci commented May 4, 2018

Build failed
Swift Test Linux Platform
Git Sha - 274598d5c1f31ce90e6cd801e79fce9e32b0296c

@swift-ci
Copy link
Contributor

swift-ci commented May 4, 2018

Build failed
Swift Test OS X Platform
Git Sha - 274598d5c1f31ce90e6cd801e79fce9e32b0296c

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test source compatibility

@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test compiler performance

@swift-ci
Copy link
Contributor

swift-ci commented May 4, 2018

Build comment file:

Summary for swift-4.2-branch smoketest

Unexpected test results, excluded stats for ReactiveCocoa

Regressions found (see below)

Debug

debug brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 41,019,698 41,166,688 146,990 0.36%
time.swift-driver.wall 68.9s 68.7s -212.3ms -0.31%

debug detailed

Regressed (3)
name old new delta delta_pct
Driver.NumDriverPipePolls 8,169 8,661 492 6.02% ⛔
Driver.NumDriverPipeReads 7,822 8,316 494 6.32% ⛔
IRModule.NumIRValueSymbols 127,402 128,710 1,308 1.03% ⛔
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (70)
name old new delta delta_pct
AST.NumASTBytesAllocated 1,970,443,931 1,970,417,531 -26,400 -0.0%
AST.NumDecls 3,193 3,193 0 0.0%
AST.NumDependencies 10,967 10,967 0 0.0%
AST.NumImportedExternalDefinitions 91,038 91,038 0 0.0%
AST.NumInfixOperators 1,291 1,291 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 12,956 12,956 0 0.0%
AST.NumLocalTypeDecls 0 0 0 0.0%
AST.NumObjCMethods 260 260 0 0.0%
AST.NumPostfixOperators 0 0 0 0.0%
AST.NumPrecedenceGroups 419 419 0 0.0%
AST.NumPrefixOperators 2 2 0 0.0%
AST.NumReferencedDynamicNames 1 1 0 0.0%
AST.NumReferencedMemberNames 142,781 142,781 0 0.0%
AST.NumReferencedTopLevelNames 9,612 9,612 0 0.0%
AST.NumSourceBuffers 51,074 51,074 0 0.0%
AST.NumSourceLines 72,568 72,568 0 0.0%
AST.NumSourceLinesPerSecond 82,424 82,797 373 0.45%
AST.NumTotalClangImportedEntities 259,146 259,146 0 0.0%
AST.NumUsedConformances 8,768 8,768 0 0.0%
Driver.ChildrenMaxRSS 2,034,962,432 2,052,569,088 17,606,656 0.87%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 411 411 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.NumProcessFailures 0 0 0 0.0%
IRModule.NumIRAliases 519 519 0 0.0%
IRModule.NumIRBasicBlocks 126,125 126,125 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRFunctions 74,450 75,104 654 0.88%
IRModule.NumIRGlobals 68,118 68,772 654 0.96%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 1,405,655 1,405,655 0 0.0%
IRModule.NumIRNamedMetaData 1,576 1,576 0 0.0%
LLVM.NumLLVMBytesOutput 41,019,698 41,166,688 146,990 0.36%
Parse.NumFunctionsParsed 4,200 4,200 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 43,437 43,437 0 0.0%
SILModule.NumSILGenGlobalVariables 1,664 1,664 0 0.0%
SILModule.NumSILGenVtables 140 140 0 0.0%
SILModule.NumSILGenWitnessTables 1,837 1,837 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 47,012 47,012 0 0.0%
SILModule.NumSILOptGlobalVariables 3,354 3,354 0 0.0%
SILModule.NumSILOptVtables 253 253 0 0.0%
SILModule.NumSILOptWitnessTables 3,289 3,289 0 0.0%
Sema.NamedLazyMemberLoadFailureCount 1,314 1,314 0 0.0%
Sema.NamedLazyMemberLoadSuccessCount 216,297 216,297 0 0.0%
Sema.NominalTypeLookupDirectCount 2,318,865 2,318,865 0 0.0%
Sema.NumConformancesDeserialized 334,011 334,011 0 0.0%
Sema.NumConstraintScopes 906,835 906,835 0 0.0%
Sema.NumDeclsDeserialized 2,239,372 2,239,372 0 0.0%
Sema.NumDeclsValidated 190,411 190,411 0 0.0%
Sema.NumFunctionsTypechecked 52,321 52,321 0 0.0%
Sema.NumGenericSignatureBuilders 61,117 61,117 0 0.0%
Sema.NumLazyGenericEnvironments 453,564 453,564 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 40,555 40,555 0 0.0%
Sema.NumLazyIterableDeclContexts 342,810 342,810 0 0.0%
Sema.NumTypesDeserialized 2,358,482 2,358,482 0 0.0%
Sema.NumTypesValidated 219,794 219,794 0 0.0%
Sema.NumUnloadedLazyIterableDeclContexts 207,267 207,267 0 0.0%

Release

release brief

Regressed (0)
name old new delta delta_pct
Improved (0)
name old new delta delta_pct
Unchanged (delta < 1.0% or delta < 100.0ms) (2)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 30,525,556 30,678,540 152,984 0.5%
time.swift-driver.wall 164.6s 164.9s 295.3ms 0.18%

release detailed

Regressed (3)
name old new delta delta_pct
IRModule.NumIRFunctions 57,298 57,952 654 1.14% ⛔
IRModule.NumIRGlobals 55,160 55,814 654 1.19% ⛔
IRModule.NumIRValueSymbols 101,126 102,434 1,308 1.29% ⛔
Improved (2)
name old new delta delta_pct
Driver.NumDriverPipePolls 9,944 9,779 -165 -1.66% ✅
Driver.NumDriverPipeReads 9,928 9,763 -165 -1.66% ✅
Unchanged (delta < 1.0% or delta < 100.0ms) (68)
name old new delta delta_pct
AST.NumASTBytesAllocated 187,933,551 187,928,160 -5,391 -0.0%
AST.NumDecls 3,193 3,193 0 0.0%
AST.NumDependencies 312 312 0 0.0%
AST.NumImportedExternalDefinitions 8,764 8,764 0 0.0%
AST.NumInfixOperators 1,291 1,291 0 0.0%
AST.NumLinkLibraries 0 0 0 0.0%
AST.NumLoadedModules 406 406 0 0.0%
AST.NumLocalTypeDecls 0 0 0 0.0%
AST.NumObjCMethods 260 260 0 0.0%
AST.NumPostfixOperators 0 0 0 0.0%
AST.NumPrecedenceGroups 419 419 0 0.0%
AST.NumPrefixOperators 2 2 0 0.0%
AST.NumReferencedDynamicNames 0 0 0 0.0%
AST.NumReferencedMemberNames 0 0 0 0.0%
AST.NumReferencedTopLevelNames 0 0 0 0.0%
AST.NumSourceBuffers 394 394 0 0.0%
AST.NumSourceLines 72,568 72,568 0 0.0%
AST.NumSourceLinesPerSecond 3,470 3,502 32 0.92%
AST.NumTotalClangImportedEntities 25,382 25,382 0 0.0%
AST.NumUsedConformances 8,774 8,774 0 0.0%
Driver.ChildrenMaxRSS 4,231,667,712 4,195,657,728 -36,009,984 -0.85%
Driver.DriverDepCascadingDynamic 0 0 0 0.0%
Driver.DriverDepCascadingExternal 0 0 0 0.0%
Driver.DriverDepCascadingMember 0 0 0 0.0%
Driver.DriverDepCascadingNominal 0 0 0 0.0%
Driver.DriverDepCascadingTopLevel 0 0 0 0.0%
Driver.DriverDepDynamic 0 0 0 0.0%
Driver.DriverDepExternal 0 0 0 0.0%
Driver.DriverDepMember 0 0 0 0.0%
Driver.DriverDepNominal 0 0 0 0.0%
Driver.DriverDepTopLevel 0 0 0 0.0%
Driver.NumDriverJobsRun 16 16 0 0.0%
Driver.NumDriverJobsSkipped 0 0 0 0.0%
Driver.NumProcessFailures 0 0 0 0.0%
Frontend.NumProcessFailures 0 0 0 0.0%
IRModule.NumIRAliases 594 594 0 0.0%
IRModule.NumIRBasicBlocks 175,025 175,025 0 0.0%
IRModule.NumIRComdatSymbols 0 0 0 0.0%
IRModule.NumIRIFuncs 0 0 0 0.0%
IRModule.NumIRInsts 1,394,785 1,394,785 0 0.0%
IRModule.NumIRNamedMetaData 1,315 1,315 0 0.0%
LLVM.NumLLVMBytesOutput 30,525,556 30,678,540 152,984 0.5%
Parse.NumFunctionsParsed 4,200 4,200 0 0.0%
SILModule.NumSILGenDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILGenFunctions 22,058 22,058 0 0.0%
SILModule.NumSILGenGlobalVariables 1,655 1,655 0 0.0%
SILModule.NumSILGenVtables 140 140 0 0.0%
SILModule.NumSILGenWitnessTables 1,303 1,303 0 0.0%
SILModule.NumSILOptDefaultWitnessTables 0 0 0 0.0%
SILModule.NumSILOptFunctions 38,760 38,760 0 0.0%
SILModule.NumSILOptGlobalVariables 1,839 1,839 0 0.0%
SILModule.NumSILOptVtables 377 377 0 0.0%
SILModule.NumSILOptWitnessTables 2,460 2,460 0 0.0%
Sema.NamedLazyMemberLoadFailureCount 156 156 0 0.0%
Sema.NamedLazyMemberLoadSuccessCount 20,071 20,071 0 0.0%
Sema.NominalTypeLookupDirectCount 910,402 910,402 0 0.0%
Sema.NumConformancesDeserialized 152,071 152,071 0 0.0%
Sema.NumConstraintScopes 801,057 801,057 0 0.0%
Sema.NumDeclsDeserialized 227,001 227,001 0 0.0%
Sema.NumDeclsValidated 59,864 59,864 0 0.0%
Sema.NumFunctionsTypechecked 10,695 10,695 0 0.0%
Sema.NumGenericSignatureBuilders 6,462 6,462 0 0.0%
Sema.NumLazyGenericEnvironments 33,650 33,650 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 4,549 4,549 0 0.0%
Sema.NumLazyIterableDeclContexts 21,390 21,390 0 0.0%
Sema.NumTypesDeserialized 278,901 278,901 0 0.0%
Sema.NumTypesValidated 40,441 40,441 0 0.0%
Sema.NumUnloadedLazyIterableDeclContexts 9,856 9,856 0 0.0%

@jrose-apple jrose-apple merged commit 1c4a3bc into swiftlang:swift-4.2-branch May 5, 2018
@jrose-apple jrose-apple deleted the 4.2-just-autolink-everything branch May 5, 2018 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrose-apple @swift-ci